Approve QCed Files

After the QCer is finished reviewing and all of their feedback implemented, they must approve the QCed file. To do this, we use the Status app.

Note

Documentation is on-going. On this page, we will not detail all of the features of the Status app.

In the meantime, we encourage you to explore the app and how it can be used in your workflow!

Instruction for how to launch the Status app and approve issues can be found below:

How to Use the Status App for Approval

Approved Issue Thread

Approval of a QC Issue is fairly straightforward, it leaves metadata within the issue for when the file was approved so that future users can reference the version of the script that was approved. Therefore, on this page we’ll spend some time reviewing the final issue thread with all of the comments.

In the below example, we can notice a few key aspects:

• The QCer was assigned as the Assignee, whether in the Assign app or self-assigned
• The QCer chose to push their comments in-line and use the Notify app
• The Author made the edits requested by the QCer and notified the changes using the Notify app
• Once the QCer was satisfied with the changes, they approved the issue.

Close Milestones

When all Issues within a Milestone are closed, you may close the Milestone.

This communicates to the other ghqc apps that the Milestone is completed.